mansi75 commented on code in PR #56:
URL: https://github.com/apache/fineract-site/pull/56#discussion_r2937125745
##########
README.md:
##########
@@ -56,6 +56,21 @@ docker run --rm -v "${PWD}:/src" -w /src/site-src
fineract-site build
docker run --rm -it -p 1313:1313 -v "${PWD}:/src" -w /src/site-src
fineract-site serve
```
+## Verifying ASF homepage footer checks locally
+
+Apache Whimsy validates that the public homepage includes specific ASF-required
+footer links and legal text. Before opening a PR, verify the footer locally.
+
+### Build and run checks
+```bash
+docker build -t fineract-site .
+docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src
fineract-site build
+docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src
fineract-site check
+
+Serve the site locally
+
+docker run --rm -it -u "$(id -u):$(id -g)" -v "$PWD:/src" -w /src/site-src -p
1313:1313 fineract-site serve
+
Review Comment:
I looked into using Whimsy directly as the dependency inside the Docker
image, and I agree with the goal of avoiding a separately maintained local copy
of the checks.
I tried invoking Whimsy’s scanner directly, but the current entrypoint pulls
in ASF-specific runtime dependencies and fails outside a fuller Whimsy/ASF
environment (it expects LDAP, the board checkout and committee data). Because
of that, I don’t think we can use the scanner unmodified in this repo’s
lightweight site image without bringing in a much larger runtime than the site
build currently has.
I have added a Ruby checker that mirrors Whimsy logic, I have kept Whimsy as
the Docker dependency and add only a very small bit of code to call Whimsy’s
current standards from within the existing site build flow, without
reimplementing the checks ourselves as I did earlier in python script.
I have checked it in the local as shown below
<img width="666" height="212" alt="Screenshot 2026-03-15 at 5 46 37 PM"
src="https://github.com/user-attachments/assets/71b82b92-abde-46d3-8189-642974c33425";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
