bagusrizkis opened a new pull request, #57: URL: https://github.com/apache/fineract-site/pull/57
## Summary Replace the theme toggle anchor (`<a href="#">`) with a `<button type="button">`, and reset background and border in CSS so the visual is identical to before. ## Why JIRA: [FINERACT-2600](https://issues.apache.org/jira/browse/FINERACT-2600) Clicking the toggle scrolled the page to top because `href="#"` triggered default anchor navigation. `<button>` is also semantically correct since the toggle doesn't navigate anywhere, and Space-key activation works for free. ## Testing Served locally and verified the bug reproduces with the original markup, then no longer reproduces after the change. Toggled multiple times across scrolled positions, theme switches in place. Visual rendering identical to before. Tested in Safari, Chrome, and Firefox. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
