[ 
https://issues.apache.org/jira/browse/FINERACT-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083456#comment-18083456
 ] 

Adam Saghy edited comment on FINERACT-2591 at 5/26/26 10:21 AM:
----------------------------------------------------------------

[~dishita2004] [~yvana] I dont think this is valid requirement. We should not 
spam the console log full of warnings just because someone does not interested 
in idempotency handling.

 

Please rework this to the following:
 * Introduce a new global configuration option: `enable-idempotency-validation`
 ** By default value is `disabled` (backward compatibility)
 * Only log on WARN level if it is enabled (use service which cache global 
configuration value)


was (Author: adamsaghy):
[~dishita2004] [~yvana] I dont think this is valid requirement. We should not 
spam the console log full of warnings just because someone does not interested 
in idempotency handling.

> Add warning when Idempotency-Key header is missing
> --------------------------------------------------
>
>                 Key: FINERACT-2591
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2591
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Dishita Suyal
>            Priority: Major
>
> This issue is based on a recent DEV mailing list discussion regarding 
> idempotency fallback behavior.
> Based on the recent DEV mailing list discussion on idempotency fallback 
> behavior, it was agreed that idempotency should remain a client 
> responsibility and server-side fallback should not be enforced.
> Currently, when the Idempotency-Key header is missing, the request is 
> processed silently, which may lead to unintended duplicate operations.
> Proposed improvement:
> - Log a warning when Idempotency-Key is missing
> - (Optional) Add a response header indicating the absence of the key
> This would improve observability and guide clients without changing existing 
> behavior.
> I’d be happy to work on this improvement if it aligns with the project 
> direction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to