elnafateh opened a new pull request, #5888: URL: https://github.com/apache/fineract/pull/5888
## Description Part of [FINERACT-2165](https://issues.apache.org/jira/browse/FINERACT-2165) — system-wide migration of integration tests from RestAssured to `fineract-client-feign`. ## Changes ### `CobHelper.java` - Removed 1 `@Deprecated(forRemoval=true)` method (`getCobPartitions`) that used RestAssured and raw URL string - Replaced with a typed feign-based `getCobPartitions(int partitionSize)` that calls `internalCob().getCobPartitions(partitionSize)` and deserializes the response - Upgraded `fastForwardLoansLastCOBDate` and `reprocessLoan` from `FineractClientHelper` to `FineractFeignClientHelper` - Removed all RestAssured and `FineractClientHelper` imports ### `SearchHelper.java` - Removed 1 `@Deprecated(forRemoval=true)` method (`getSearch`) that used RestAssured, GSON, and raw URL string construction - Replaced with a typed feign-based `getSearch(query, exactMatch, resources)` that calls `search().searchData(query, resources, exactMatch)` returning `List<GetSearchResponse>` - Removed all RestAssured, GSON, and URL string imports ### `ShareAccountHelper.java` - Removed `@Deprecated(forRemoval=true)` annotation from `build()` — the method has active callers that will be addressed in a follow-up migration of the Share test suite - Removed unused `Logger`/`LoggerFactory` fields and imports ### `CobPartitioningTest.java` - Updated the single caller of the deprecated `getCobPartitions` to use the new signature `CobHelper.getCobPartitions(3)` — no assertion logic changed ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
