elnafateh commented on code in PR #5888:
URL: https://github.com/apache/fineract/pull/5888#discussion_r3303395391
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareAccountHelper.java:
##########
@@ -146,4 +80,38 @@ public ShareAccountHelper withCharges(final
List<Map<String, Object>> charges) {
this.charges.addAll(charges);
return this;
}
+
+ public String build() {
Review Comment:
Fair point — `build()` callers all depend on other deprecated RestAssured
helpers
(e.g. `ShareProductTransactionHelper`). I intended to address that in a
dedicated Share helpers PR
to keep scope clean. but I'd be happy to change if you think otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
