Cocoa-Puffs commented on code in PR #5971: URL: https://github.com/apache/fineract/pull/5971#discussion_r3441024449
########## fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanOriginatorWritePlatformService.java: ########## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.workingcapitalloan.service; + +import lombok.RequiredArgsConstructor; +import org.apache.fineract.infrastructure.core.api.JsonCommand; +import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; +import org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginator; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginatorRepository; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginatorStatus; +import org.apache.fineract.portfolio.loanorigination.domain.WorkingCapitalLoanOriginatorMapping; +import org.apache.fineract.portfolio.loanorigination.domain.WorkingCapitalLoanOriginatorMappingRepository; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorMappingAlreadyExistsException; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorNotActiveException; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorNotFoundException; +import org.apache.fineract.portfolio.loanorigination.exception.WorkingCapitalLoanOriginatorMappingNotFoundException; +import org.apache.fineract.portfolio.loanorigination.service.LoanOriginatorWritePlatformService; +import org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoan; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanApplicationNotInSubmittedStateCannotBeDeletedException; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotFoundException; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotInSubmittedStatusException; +import org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanRepository; +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; + +@Service +@RequiredArgsConstructor +@Transactional +@ConditionalOnProperty(value = "fineract.module.loan-origination.enabled", havingValue = "true") +public class WorkingCapitalLoanOriginatorWritePlatformService implements LoanOriginatorWritePlatformService { + + private final WorkingCapitalLoanRepository workingCapitalLoanRepository; + private final LoanOriginatorRepository loanOriginatorRepository; + private final WorkingCapitalLoanOriginatorMappingRepository workingCapitalLoanOriginatorMappingRepository; + + @Override + public CommandProcessingResult create(final JsonCommand command) { + throw new UnsupportedOperationException("Use LoanOriginatorWritePlatformService for originator creation"); + } + + @Override + public CommandProcessingResult update(final Long id, final JsonCommand command) { + throw new UnsupportedOperationException("Use LoanOriginatorWritePlatformService for originator updates"); + } + + @Override + public CommandProcessingResult delete(final Long id) { + throw new UnsupportedOperationException("Use LoanOriginatorWritePlatformService for originator deletion"); + } + + @Override + public CommandProcessingResult attachOriginatorToLoan(final Long loanId, final Long originatorId) { + final WorkingCapitalLoan loan = this.workingCapitalLoanRepository.findById(loanId) + .orElseThrow(() -> new WorkingCapitalLoanNotFoundException(loanId)); + + if (!loan.getLoanStatus().isSubmittedAndPendingApproval()) { + throw new WorkingCapitalLoanNotInSubmittedStatusException(loanId, loan.getLoanStatus().getCode()); + } + + final LoanOriginator originator = this.loanOriginatorRepository.findById(originatorId) + .orElseThrow(() -> new LoanOriginatorNotFoundException(originatorId)); + + if (originator.getStatus() != LoanOriginatorStatus.ACTIVE) { + throw new LoanOriginatorNotActiveException(originatorId, originator.getStatus().getValue()); + } + + if (this.workingCapitalLoanOriginatorMappingRepository.existsByLoanIdAndOriginatorId(loanId, originatorId)) { + throw new LoanOriginatorMappingAlreadyExistsException(loanId, originatorId); + } + + final WorkingCapitalLoanOriginatorMapping mapping = WorkingCapitalLoanOriginatorMapping.create(loanId, originator); + this.workingCapitalLoanOriginatorMappingRepository.saveAndFlush(mapping); + + return new CommandProcessingResultBuilder() // + .withEntityId(loanId) // + .withEntityExternalId(loan.getExternalId()) // + .withSubEntityId(originatorId) // + .withSubEntityExternalId(originator.getExternalId()) // + .build(); + } + + @Override + public CommandProcessingResult detachOriginatorFromLoan(final Long loanId, final Long originatorId) { + final WorkingCapitalLoan loan = this.workingCapitalLoanRepository.findById(loanId) + .orElseThrow(() -> new WorkingCapitalLoanNotFoundException(loanId)); + + if (!loan.getLoanStatus().isSubmittedAndPendingApproval()) { + throw new WorkingCapitalLoanApplicationNotInSubmittedStateCannotBeDeletedException(loanId); Review Comment: replaced with the appropriate exception ########## fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanOriginatorWritePlatformService.java: ########## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.workingcapitalloan.service; + +import lombok.RequiredArgsConstructor; +import org.apache.fineract.infrastructure.core.api.JsonCommand; +import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; +import org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginator; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginatorRepository; +import org.apache.fineract.portfolio.loanorigination.domain.LoanOriginatorStatus; +import org.apache.fineract.portfolio.loanorigination.domain.WorkingCapitalLoanOriginatorMapping; +import org.apache.fineract.portfolio.loanorigination.domain.WorkingCapitalLoanOriginatorMappingRepository; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorMappingAlreadyExistsException; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorNotActiveException; +import org.apache.fineract.portfolio.loanorigination.exception.LoanOriginatorNotFoundException; +import org.apache.fineract.portfolio.loanorigination.exception.WorkingCapitalLoanOriginatorMappingNotFoundException; +import org.apache.fineract.portfolio.loanorigination.service.LoanOriginatorWritePlatformService; +import org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoan; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanApplicationNotInSubmittedStateCannotBeDeletedException; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotFoundException; +import org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotInSubmittedStatusException; +import org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanRepository; +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; + +@Service +@RequiredArgsConstructor +@Transactional +@ConditionalOnProperty(value = "fineract.module.loan-origination.enabled", havingValue = "true") +public class WorkingCapitalLoanOriginatorWritePlatformService implements LoanOriginatorWritePlatformService { Review Comment: Dropped the implements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
