Cocoa-Puffs commented on PR #5971: URL: https://github.com/apache/fineract/pull/5971#issuecomment-4770408119
> **Things to be considered** > > **Doc/permission mismatch (should fix).** > > The WC attach/detach @operation descriptions say "Requires ATTACH_LOAN_ORIGINATOR / DETACH_LOAN_ORIGINATOR permission", but the command entity is WORKING_CAPITAL_LOAN_ORIGINATOR and the migration seeds ATTACH_WORKING_CAPITAL_LOAN_ORIGINATOR / DETACH_WORKING_CAPITAL_LOAN_ORIGINATOR. The Swagger text is a stale copy-paste and will mislead API consumers about which permission to grant. > > **Module placement inconsistency (worth a look).** > > WorkingCapitalLoanOriginatorMapping, its repository, and WorkingCapitalLoanOriginatorMappingNotFoundException live in the loanorigination module, while every other WC originator class (services, handlers, API resource, the not-in-submitted-status exception) lives in the workingcapitalloan module. These WC-specific classes only reference loan_id as a plain Long, so nothing forces them into the origination module — placing them with the rest of the WC code would be more consistent with how the feature is otherwise split. I have moved everything I could into the originators module. some things stayed because they depend on wc module content. WorkingCapitalLoanOriginatorsApiResource.java — depends on WorkingCapitalLoanConstants, WorkingCapitalLoanNotFoundException, and WorkingCapitalLoanApplicationReadPlatformService (all WC module). Cannot move. WorkingCapitalLoanOriginatorWritePlatformService.java — depends on WorkingCapitalLoan, WorkingCapitalLoanRepository, and WorkingCapitalLoanNotFoundException (all WC module). Cannot move. AttachWorkingCapitalLoanOriginatorCommandHandler.java — depends on WorkingCapitalLoanOriginatorWritePlatformService (WC module). Cannot move. DetachWorkingCapitalLoanOriginatorCommandHandler.java — same as above. Cannot move. Other than these newly created files the other are in the originators module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
