DhroovSankla commented on PR #6017: URL: https://github.com/apache/fineract/pull/6017#issuecomment-4809671657
> I dont really see any additional value of this PR. > > @DhroovSankla Can you please advise what were you trying to improve here? Hi @adamsaghy, Thank you for reviewing this PR! The primary intention here was to address the legacy technical debt comment left inline within this module: `// TODO: make this type safe?`. Architecturally, wrapping the XML string payload inside a JAX-RS `Response` object decouples the business layer data from the transport configuration. By returning a formal `Response` entity instead of a raw `String`, it allows explicit framework control over response metadata, headers, and content negotiation via `.type(MediaType.APPLICATION_XML_TYPE)`. This future-proofs the resource for adding alternative status codes or custom headers seamlessly down the line without changing the core method signature logic. Please let me know if you would prefer to retain the legacy raw String approach or if this architectural alignment fits the current standards of the project! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
