Dhanno98 commented on PR #5940: URL: https://github.com/apache/fineract/pull/5940#issuecomment-4812624291
> @Dhanno98 Please review the failing checks Hi @adamsaghy ! I investigated the CI failures. One of the failures (`LoanWorkbookPopulatorTest.testLoanWorkbookPopulate`) was reproducible locally only when `ClientChargeRoundingTest` was executed before it. After tracing the failure, I found that `ClientChargeRoundingTest` created client charges using UUIDs in the charge name. Those UUIDs contained hyphens, which later became part of workbook named ranges created by `LoanWorkbookPopulator`, causing the subsequent workbook population test to fail. I've updated the `createFlatClientCharge()` to remove the hyphens from the UUID while still keeping the names unique. After this change I verified that: * `ClientChargeRoundingTest` passes. * `LoanWorkbookPopulatorTest` passes even when run immediately after `ClientChargeRoundingTest`. I've amended the PR with this fix. The other CI failure (`MariaDB Tests` -> `Build the image`) also seems unrelated to this change. From the logs, it failed with: `java.net.UnknownHostException: registry-1.docker.io: Temporary failure in name resolution` Since the PostgreSQL and MySQL jobs passed, I think this might be a temporary CI/network issue rather than something caused by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
