Dhanno98 commented on PR #5940: URL: https://github.com/apache/fineract/pull/5940#issuecomment-4858908909
Hi @adamsaghy While implementing the integration test for the accounting-rule-2 share product flow, I noticed that the POST `/products/share` endpoint accepts the accounting mapping fields (`shareReferenceId`, `shareSuspenseId`, `incomeFromFeeAccountId`, `shareEquityId`) when called directly (via Postman), but these fields are missing from `ProductsApiResourceSwagger.PostProductsTypeRequest`. Because of that, the generated `PostProductsTypeRequest` model also doesn't expose these fields, making it impossible to create an accounting-rule-2 share product through the generated Feign client used by the integration tests. My understanding is that the Swagger request schema is incomplete rather than the backend implementation. My plan is to add these optional request fields to the OpenAPI schema and regenerate the client. Before doing that, I wanted to check whether this is the preferred approach, since it may affect the OpenAPI backward compatibility checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
