vidakovic commented on code in PR #6085:
URL: https://github.com/apache/fineract/pull/6085#discussion_r3537918978
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java:
##########
@@ -29,51 +28,23 @@
import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
import
org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder;
import org.apache.fineract.infrastructure.core.service.DateUtils;
-import
org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
import org.apache.fineract.portfolio.address.domain.Address;
import org.apache.fineract.portfolio.address.domain.AddressRepository;
-import
org.apache.fineract.portfolio.address.exception.AddressNotFoundException;
import
org.apache.fineract.portfolio.address.serialization.AddressCommandFromApiJsonDeserializer;
import org.apache.fineract.portfolio.client.domain.Client;
import org.apache.fineract.portfolio.client.domain.ClientAddress;
import org.apache.fineract.portfolio.client.domain.ClientAddressRepository;
-import
org.apache.fineract.portfolio.client.domain.ClientAddressRepositoryWrapper;
-import org.apache.fineract.portfolio.client.domain.ClientRepositoryWrapper;
import org.springframework.stereotype.Service;
@Service
@RequiredArgsConstructor
public class AddressWritePlatformServiceImpl implements
AddressWritePlatformService {
- private final PlatformSecurityContext context;
private final CodeValueRepository codeValueRepository;
private final ClientAddressRepository clientAddressRepository;
- private final ClientRepositoryWrapper clientRepositoryWrapper;
private final AddressRepository addressRepository;
- private final ClientAddressRepositoryWrapper
clientAddressRepositoryWrapper;
private final AddressCommandFromApiJsonDeserializer
fromApiJsonDeserializer;
Review Comment:
We said no manual JSON de-/serialization? Why would we need this one here?
Please make sure that we don't use this and find a solution that works out of
the box with Jackson... and I don't mean that you use ObjectMapper or similar
here... just plain Java POJOs, nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
