vidakovic commented on code in PR #6085:
URL: https://github.com/apache/fineract/pull/6085#discussion_r3537876806
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java:
##########
@@ -397,6 +397,13 @@ public SecurityFilterChain filterChain(HttpSecurity http)
throws Exception {
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"UPDATE_HOOK")
.requestMatchers(API_MATCHER.matcher(HttpMethod.DELETE,
"/api/*/hooks/*"))
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"DELETE_HOOK")
+
Review Comment:
Seems like a minor thing, but try to avoid inserting blocks of code like
this in the middle of previous changes... like this authorization configuration
list in `SecurityConfig`. Maybe it makes more sense for you to put the client
definitions at this position in the file, but for Git this means that you are
potentially creating conflict situations that are hard to resolve, especially
when other devs are working in the same area (and they are).
Pro tip: just go to the last entry of those authorization definitions and
insert your (client) related definitions after the last entry. This is much
easier to resolve and a lot nicer to your fellow developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
