vidakovic commented on code in PR #6015:
URL: https://github.com/apache/fineract/pull/6015#discussion_r3538062070
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -345,6 +350,55 @@ public CommandProcessingResult updateCenter(final Long
centerId, final JsonComma
return updateGroupingType(centerId, command, GroupTypes.CENTER);
}
+ @Override
+ @Transactional
+ public GroupUpdateResponse updateGroup(final GroupUpdateRequest request) {
+
+ this.context.authenticatedUser();
+
+ final Group group =
this.groupRepository.findOneWithNotFoundDetection(request.getGroupId());
+
+ final String groupHierarchy = group.getOffice().getHierarchy();
+
+ this.context.validateAccessRights(groupHierarchy);
+
+ final Map<String, Object> changes = new HashMap<>();
+
+ if (StringUtils.isNotBlank(request.getName()) &&
!Objects.equals(request.getName(), group.getName())) {
+
+ group.setName(request.getName());
+ changes.put(GroupUpdateRequest.Fields.name, request.getName());
+ }
+
+ if (!Objects.equals(request.getExternalId(), group.getExternalId())) {
+
+ group.setExternalId(request.getExternalId());
+ changes.put(GroupUpdateRequest.Fields.externalId,
request.getExternalId());
+ }
+
+ if (request.getStaffId() != null) {
+
+ final Staff newStaff =
this.staffRepository.findByOfficeHierarchyWithNotFoundDetection(request.getStaffId(),
groupHierarchy);
+
+ group.updateStaff(newStaff);
+
+ changes.put(GroupUpdateRequest.Fields.staffId,
request.getStaffId());
+ }
+
+ if (request.getCenterId() != null) {
+
+ final Group parentGroup =
this.groupRepository.findOneWithNotFoundDetection(request.getCenterId());
+
+ group.setParent(parentGroup);
+ group.generateHierarchy();
+
+ changes.put(GroupUpdateRequest.Fields.centerId,
request.getCenterId());
+ }
+
+ return
GroupUpdateResponse.builder().resourceId(group.getId()).groupId(group.getId()).officeId(group.officeId()).changes(changes)
+ .build();
+ }
+
@Transactional
@Override
public CommandProcessingResult updateGroup(final Long groupId, final
JsonCommand command) {
Review Comment:
Nope, belongs to legacy command processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
