nidhiii128 commented on PR #6015:
URL: https://github.com/apache/fineract/pull/6015#issuecomment-4968467591
Thanks for the review. @vidakovic
Directly flagged:
1. SecurityConfig `// group` block consolidated at the END of the
authorization list (POST + PUT + DELETE all together, right before
twofactor).
2. @ApiResponse(200) removed from the typed update and delete endpoints.
3. Legacy updateGroup(Long, JsonCommand) and closeGroup(Long, JsonCommand)
deleted from GroupingTypesWritePlatformService (interface + impl).
4. Mock tests kept.
1. Legacy deleteGroup(Long) deleted; DeleteCenterCommandHandler now bridges
to the typed deleteGroup(GroupDeleteRequest) (CENTER migration is out of scope
for this PR).
2. Legacy CloseGroupCommandHandler deleted.
3. CommandWrapperBuilder.closeGroup() deleted.
4. Added dedicated typed POST /groups/{groupId}/close endpoint with Jackson
binding, removed the command=close branch from
activateOrGenerateCollectionSheet.
5. context.authenticatedUser() removed from typed updateGroup and closeGroup
closedBy audit will be null until we align on a broader audit strategy.
6. 4 new files for close (Request, Response, Command, Handler with @Retry)
matching the update/delete pattern.
7. Retry config commandGroupClose added to application.properties.
This PR now migrates update+delete+close to typed dispatch with zero
JsonCommand in the Group service interface for these operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
