vidakovic commented on code in PR #6007:
URL: https://github.com/apache/fineract/pull/6007#discussion_r3538096594
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java:
##########
@@ -321,15 +326,11 @@ public String retrieveOne(@Context final UriInfo uriInfo,
@PathParam("groupId")
+ "Mandatory Fields: name, officeId, active, activationDate (if
active=true)\n\n"
+ "Optional Fields: externalId, staffId, clientMembers")
@RequestBody(required = true, content = @Content(schema =
@Schema(implementation = GroupsApiResourceSwagger.PostGroupsRequest.class)))
- @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
GroupsApiResourceSwagger.PostGroupsResponse.class)))
- public String create(@Parameter(hidden = true) final String
apiRequestBodyAsJson) {
-
- final CommandWrapper commandRequest = new CommandWrapperBuilder() //
- .createGroup() //
- .withJson(apiRequestBodyAsJson) //
- .build(); //
- final CommandProcessingResult result =
commandsSourceWritePlatformService.logCommandSource(commandRequest);
- return toApiJsonSerializer.serialize(result);
+ @ApiResponse(responseCode = "200", description = "OK")
Review Comment:
Trivial, unnecessary. Please avoid... apply to other occurrences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
