nidhiii128 commented on PR #6007: URL: https://github.com/apache/fineract/pull/6007#issuecomment-4966896114
Thanks for the review. @vidakovic Went beyond the two explicit flags and applied a full pass against all 8 principles you've stated across PRs: Directly flagged: 1. // group entry moved to end of authorization list. @apiresponse(200) removed from the migrated create endpoint. 2. Mock test kept. 3. Legacy createGroup(Long, JsonCommand) deleted from GroupingTypesWritePlatformService (interface + impl). 4. CommandWrapperBuilder.createGroup() deleted. 5. GroupImportHandler migrated to typed dispatch via CommandDispatcher + GroupCreateCommand. 6. context.authenticatedUser() removed from typed createGroup(GroupCreateRequest). 7. Rollback validation via CommandWrapperBuilder removed. 8. GroupsCreateBusinessEvent refactored to accept Group entity directly. 9. NotificationDomainService listener updated. 10. Added typed overload saveDatatables(..., List) to EntityDatatableChecksWritePlatformService. My createGroup call uses the typed variant now — no manual JsonArray/JsonObject construction in my service code. Result: PR grew to ~18 files but no principle is compromised in the create path. Happy to split any of the cross-file changes into a separate PR if you'd prefer smaller review chunks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
