mansi75 opened a new pull request, #6106:
URL: https://github.com/apache/fineract/pull/6106

   ## Description
   
   This PR addresses FINERACT-2646 by decoupling the accounting module from the 
charge domain dependency.
   
   The accounting code previously depended on charge domain objects directly. 
This change updates the accounting side to use the 'chargeId' reference 
instead, so accounting can identify and process charge-related mappings without 
requiring a direct dependency on the charge package/module.
   
   This helps improve module boundaries and supports the ongoing Fineract 
modularization effort by reducing cross-feature coupling between accounting and 
charge. FINERACT-2646 is listed as a sub-task for decoupling the accounting 
package/module from third-party domains. :contentReference[oaicite:0]{index=0}
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to