vidakovic commented on code in PR #6106:
URL: https://github.com/apache/fineract/pull/6106#discussion_r3571017257
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -613,10 +613,18 @@ private void savePaymentChannelToFundSourceMapping(final
Long productId, final L
*/
private void saveChargeToFundSourceMapping(final Long productId, final
Long chargeId, final Long incomeAccountId,
final PortfolioProductType portfolioProductType, final boolean
isPenalty) {
- final Charge charge =
this.chargeRepositoryWrapper.findOneWithNotFoundDetection(chargeId);
+ // The accounting module no longer loads the Charge entity (it is
decoupled from the charge domain), so the
Review Comment:
Is this something inserted by Copilot? If not: the code itself is maybe not
the proper place to put documentation like this. I know, it's there are not
really hard criteria on how much you should or could comment, but this here
looks rather large and in fact the changed code should speak for itself... if
it doesn't then maybe something is not entirely clear in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
