nidhiii128 commented on PR #6049: URL: https://github.com/apache/fineract/pull/6049#issuecomment-4955259280
Thanks for the review @vidakovic , here's what I changed: 1. Deleted addClientAddress from CommandWrapperBuilder. 2. Deleted addClientAddress + addNewClientAddress from 3. AddressWritePlatformService (interface + impl), including the private createAddress / createClientAddress helpers. 4. Migrated the caller in ClientWritePlatformServiceJpaRepositoryImpl. createClient -> it now builds typed AddressCreateRequest objects and calls AddressDomainService.create() directly. createClient itself is still JsonCommand end-to-end (its full typed migration is a separate PR since it's a large surface), so the request is populated via fromApiJsonHelper matching the pattern since the rest of that method already uses. 5. Removed context.authenticatedUser() from AddressDomainServiceImpl.create. 6. Reverted the HashMap regression in ClientHelper / ClientTest back to typed AddressCreateResponse. 7. Moved the SecurityConfig client/addresses entry to the end of the authorization list. 8. Kept the mock test in place per your comment. updateClientAddress kept on the interface for now it's migrated in the stacked PR https://github.com/apache/fineract/pull/6085. AddressCommandFromApiJsonDeserializer kept in the impl because updateClientAddress still uses it. Removed in https://github.com/apache/fineract/pull/6085 along with the update migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
