elnafateh commented on code in PR #6100:
URL: https://github.com/apache/fineract/pull/6100#discussion_r3590979842
##########
fineract-provider/src/main/java/org/apache/fineract/commands/api/AuditsApiResource.java:
##########
@@ -66,6 +69,7 @@ public class AuditsApiResource {
+ "\n" + "Example Requests:\n" + "\n" + "audits\n" + "\n" +
"audits?fields=madeOnDate,maker,processingResult\n" + "\n"
+ "audits?makerDateTimeFrom=2013-03-25
08:00:00&makerDateTimeTo=2013-04-04 18:00:00\n" + "\n" + "audits?officeId=1\n"
+ "\n"
+ "audits?officeId=1&includeJson=true")
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
AuditsApiResourceSwagger.PageGetAuditsResponse.class)))
Review Comment:
@adamsaghy Fair point , the schema shouldn't claim one shape when the wire
response actually depends on paged. Same ambiguity already exists in
`GroupsApiResource/CentersApiResource/FixedDepositAccountsApiResource `(all
document only the wrapper shape too), so it's not a new pattern, but that
doesn't make it fully accurate here either. pls what do u think I should do
here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
