elnafateh commented on code in PR #6100:
URL: https://github.com/apache/fineract/pull/6100#discussion_r3652520337


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/InternalLoanInformationApiResource.java:
##########
@@ -72,23 +72,23 @@ public void afterPropertiesSet() {
     @Path("{loanId}/audit")
     @Produces({ MediaType.APPLICATION_JSON })
     @SuppressFBWarnings("SLF4J_SIGN_ONLY_FORMAT")
-    public AuditData getLoanAuditFields(@Context final UriInfo uriInfo, 
@PathParam("loanId") Long loanId) {
+    public LoanAuditFieldsData getLoanAuditFields(@Context final UriInfo 
uriInfo, @PathParam("loanId") Long loanId) {

Review Comment:
   Renamed it because it collided with another AuditData class from the audits 
endpoints — same name, different package, but OpenAPI schema naming doesn't 
distinguish packages, so one was silently overwriting the other. This one's 
private and only used in this file, so renaming it was the safe fix with zero 
side effects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to