adamsaghy commented on code in PR #6069:
URL: https://github.com/apache/fineract/pull/6069#discussion_r3631016985
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/COBFilterApiMatcher.java:
##########
@@ -20,17 +20,19 @@
import static
org.apache.fineract.batch.command.CommandStrategyUtils.isRelativeUrlVersioned;
-import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.ObjectMapper;
import java.io.IOException;
import java.util.List;
import org.apache.commons.lang3.StringUtils;
import org.apache.fineract.batch.domain.BatchRequest;
import
org.apache.fineract.infrastructure.core.http.BodyCachingHttpServletRequestWrapper;
+import tools.jackson.core.json.JsonReadFeature;
+import tools.jackson.core.type.TypeReference;
+import tools.jackson.databind.ObjectMapper;
+import tools.jackson.databind.json.JsonMapper;
public abstract class COBFilterApiMatcher implements COBFilterHelper {
- protected final ObjectMapper objectMapper = new ObjectMapper();
+ protected final ObjectMapper objectMapper =
JsonMapper.builder().enable(JsonReadFeature.ALLOW_UNESCAPED_CONTROL_CHARS).build();
Review Comment:
Are these two interchangeable? Is it correct to allow "unescaped control
chars"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
