adamsaghy commented on code in PR #6069:
URL: https://github.com/apache/fineract/pull/6069#discussion_r3631037724
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBFilterHelperImpl.java:
##########
@@ -191,12 +188,14 @@ private List<Long>
getLoanIdsFromBatchApi(BodyCachingHttpServletRequestWrapper r
return loanIds;
}
- private Long getTopLevelLoanIdFromBatchRequest(BatchRequest batchRequest)
throws JsonProcessingException {
+ private Long getTopLevelLoanIdFromBatchRequest(BatchRequest batchRequest) {
String body = batchRequest.getBody();
if (StringUtils.isNotBlank(body)) {
JsonNode jsonNode = objectMapper.readTree(body);
if (jsonNode.has("loanId")) {
- return jsonNode.get("loanId").asLong();
Review Comment:
At this point we cannot have unresolved references, if we have, that might
be an issue and need to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
