budaidev commented on code in PR #6158:
URL: https://github.com/apache/fineract/pull/6158#discussion_r3643617070
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/LoanTestValidators.java:
##########
@@ -96,8 +96,9 @@ public static void verifyTransactions(GetLoansLoanIdResponse
loanDetails, LoanTe
&&
Objects.equals(Utils.getDoubleValue(item.getFeeChargesPortion()), tr.feePortion)
&&
Objects.equals(Utils.getDoubleValue(item.getPenaltyChargesPortion()),
tr.penaltyPortion)
&&
Objects.equals(Utils.getDoubleValue(item.getOverpaymentPortion()),
tr.overpaymentPortion)
- &&
Objects.equals(Utils.getDoubleValue(item.getUnrecognizedIncomePortion()),
tr.unrecognizedPortion)
- && (tr.reversed == null ||
Objects.equals(item.getManuallyReversed(), tr.reversed)));
+ &&
Objects.equals(Utils.getDoubleValue(item.getUnrecognizedIncomePortion()),
tr.unrecognizedPortion));
Review Comment:
I don't think your thought about this was wrong, since you followed the
pattern we had, but I think it would be better to keep the possibility to be
able to distinguish the reverse transactions from the others.
In certain cases it could contain valuable information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
