DeathGun44 commented on code in PR #6158:
URL: https://github.com/apache/fineract/pull/6158#discussion_r3650713574
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/LoanTestValidators.java:
##########
@@ -96,8 +96,9 @@ public static void verifyTransactions(GetLoansLoanIdResponse
loanDetails, LoanTe
&&
Objects.equals(Utils.getDoubleValue(item.getFeeChargesPortion()), tr.feePortion)
&&
Objects.equals(Utils.getDoubleValue(item.getPenaltyChargesPortion()),
tr.penaltyPortion)
&&
Objects.equals(Utils.getDoubleValue(item.getOverpaymentPortion()),
tr.overpaymentPortion)
- &&
Objects.equals(Utils.getDoubleValue(item.getUnrecognizedIncomePortion()),
tr.unrecognizedPortion)
- && (tr.reversed == null ||
Objects.equals(item.getManuallyReversed(), tr.reversed)));
+ &&
Objects.equals(Utils.getDoubleValue(item.getUnrecognizedIncomePortion()),
tr.unrecognizedPortion));
Review Comment:
Thanks! I actually had the reversed check in there originally, then removed
it to match the base verifyTransactions(Long, TransactionExt...) in
BaseLoanIntegrationTest, which doesn't check reversed either ,I wanted the
Feign version to behave exactly like the one it's replacing so the migration
stays a faithful port.
There's also a practical reason the base skips it: TransactionExt.reversed
defaults to false, but the API returns manuallyReversed = null for non-reversed
transactions, so a plain equals check would fail every normal transaction.
Happy to add it back with null-handling if you'd like!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
