codigm opened a new pull request, #6177:
URL: https://github.com/apache/fineract/pull/6177
## Description
Resolves FINERACT-405.
This PR standardizes mobile number validation across the Client and Staff
modules.
Previously, the regular expression `^\+?[0-9]{7,15}$` was duplicated across
three different files (`ClientDataValidator`, `StaffCreateRequest`, and
`StaffUpdateRequest`).
This PR extracts the regex into a centralized `ValidationConstants.java`
utility class in `fineract-core` and updates all references to use this single
source of truth, improving maintainability.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [x] Write the commit message as per our guidelines
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes
made. *(Note: Not applicable, as existing tests cover this refactor)*
- [x] Follow our coding conventions
- [ ] Add required Swagger annotation and update API documentation *(Note:
Not applicable, no API signatures changed)*
- [x] This PR must not be a "code dump"
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
