adamsaghy commented on code in PR #6124:
URL: https://github.com/apache/fineract/pull/6124#discussion_r3656052220
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -638,6 +640,8 @@ private void validateBusinessRulesForJournalEntries(final
JournalEntryCommand co
null, null);
}
}
+ // shouldn't be backdated beyond the configured window (FINERACT-1950)
+
this.backdatedTransactionValidationService.validateTransactionDate(transactionDate);
Review Comment:
Validating whether backdated transactions are allowed or not has nothing to
do with accounting. Why do you think we should have this validation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
