Abhishek6122008 commented on code in PR #6124:
URL: https://github.com/apache/fineract/pull/6124#discussion_r3658645853
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -638,6 +640,8 @@ private void validateBusinessRulesForJournalEntries(final
JournalEntryCommand co
null, null);
}
}
+ // shouldn't be backdated beyond the configured window (FINERACT-1950)
+
this.backdatedTransactionValidationService.validateTransactionDate(transactionDate);
Review Comment:
On a second reading of the story, it explicitly mentions that accountants
should still be able to post backdated GL transactions. In light of that, I'll
remove the journal-entry validation and keep this change limited to portfolio
(loan/savings) transactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
