AshharAhmadKhan opened a new pull request, #6190: URL: https://github.com/apache/fineract/pull/6190
JIRA https://issues.apache.org/jira/browse/FINERACT-2716 Problem The previewMessage-equivalent method in SmsCampaignWritePlatformServiceJpaImpl caught IOException from JSON parsing and did nothing with it. No log, no rethrow. The failure disappeared silently. Fix Replaced the // TODO throw something here with a log.error call. This was the last remaining instance of this pattern in the class - every other catch (IOException ...) block here already logs and continues. This is a direct follow-up to FINERACT-2707, which fixed the equivalent issue in EmailCampaignWritePlatformCommandHandlerImpl, and to the note left in that PR flagging this exact method as the one remaining spot. I also grepped the full codebase for "TODO throw something here" and for any other silent catch (IOException e) {} blocks - this was the only remaining occurrence; everything else already logs. No functional change otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
