adamsaghy commented on code in PR #6190:
URL: https://github.com/apache/fineract/pull/6190#discussion_r3704998281
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignWritePlatformServiceJpaImpl.java:
##########
@@ -526,7 +526,7 @@ public CampaignPreviewData previewMessage(final JsonQuery
query) {
campaignMessage = new CampaignPreviewData(textMessageTemplate,
0);
}
} catch (final IOException e) {
- // TODO throw something here
+ log.error("Failed to parse campaign params while generating SMS
campaign preview message", e);
Review Comment:
I would rather throw an error and let the caller aware, it failed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
