DeathGun44 opened a new pull request, #6194: URL: https://github.com/apache/fineract/pull/6194
## What this PR does Migrates the **group and center integration tests** from the old REST-assured HTTP client to the typed Feign SDK client ## Why The old tests call the server with hand-written REST-assured requests and read untyped JSON. Moving them onto the generated Feign client gives typed requests and responses, so the tests are safer to change and consistent with the rest of the migrated suite. ## What changed **Test classes migrated** - `CenterIntegrationTest` - `GroupTest` - `GroupLoanIntegrationTest` **New typed helpers**: - `FeignGroupHelper`, `FeignCenterHelper`, `FeignStaffHelper`, `FeignGlimHelper` **Removed the old stopgap:** - Deleted `FeignGroupCenterHelper` (a raw-HTTP helper from an earlier PR) and repointed its two users `LoanReschedulingWithinCenterTest` and `ExternalIdSupportIntegrationTest` - at the new typed helpers. **Production change (minimal, additive):** - Added the missing fields to `PostGroupsRequest` and `PostCentersRequest` in the Swagger DTOs so groups and centers can be created through the typed model. These are additive only - the API wire format is unchanged. ## Where raw HTTP is still used (and why) A few calls still go through `FeignRawHttpHelper` (plain `HttpURLConnection`, not REST-assured) - only where the generated models genuinely can't express what the test asserts: - group `active` / `clientMembers` and center fields the response models don't expose, - shared `?command=...` endpoints whose request models don't carry the command fields, - the GLIM application / approve / retrieval flow (multi-child; returns fields the SDK doesn't model). Each is documented at the call site. No assertion was weakened and no REST-assured was introduced. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
