DeathGun44 commented on PR #6194:
URL: https://github.com/apache/fineract/pull/6194#issuecomment-5167661591
> Why the `FeignRawHttpHelper` usages? We would like to avoid serializing
back and forth json objects...
Done!
One thing I couldn't express in the spec. GET /centers and GET /groups
return a plain JSON array unless you pass paged=true, but an operation can only
declare one response schema (the paged one), so the generated client can't
decode the array. Rather than document the endpoint incorrectly, I bound those
requests to the generated page-item models through a small Feign interface
(NonPagedListingApi) - same pattern as the existing InternalExternalEventsApi.
Still fully typed, no JSON parsing.
To be straight about it, only one of its three methods is really forced:
- listOrphanGroups has to stay non-paged, because retrievePagedAll ignores
orphansOnly. I checked against a running server: after attaching every group of
an office to a center, the non-paged call returns [] while the paged call
returns both groups with centerId set. That looks like a server-side
inconsistency - happy to raise a separate ticket if you agree.
- The two center listings could use paged=true. I kept them non-paged only
so testListCenters still compares the two shapes rather than comparing a call
to itself. Glad to switch if you'd rather.
I also relaxed testListCenters to compare by id - neither branch applies an
ORDER BY unless you ask for one, so the element-wise comparison was passing by
luck.
Rebased onto current develop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
