AnvayKharb commented on PR #6187: URL: https://github.com/apache/fineract/pull/6187#issuecomment-5141254132
Thanks for the guidance. I updated the PR to follow the separate optional transaction time approach instead of the earlier combined date-time design. Current implementation: - Keeps the existing transaction date fields unchanged. - Adds an optional separate transactionTime field using OffsetTime. - Accepts ISO offset time values such as 14:30:00+05:30, 04:15:30-04:00, and 09:00:00Z. - Normalizes provided transactionTime values to UTC before persistence. - Leaves date-only requests fully backward compatible with transactionTime omitted/null. - Uses PostgreSQL TIME WITH TIME ZONE and MySQL/MariaDB TIME(6). - Removes the earlier combined transaction_datetime/TIMESTAMP/LocalDateTime approach. I also rechecked the diff for newly introduced LocalDateTime, transaction_datetime, transactionDateTime, .atStartOfDay(), midnight conversions, and generic TIMESTAMP usage; none remain in this PR diff. Local validation passed for OpenAPI compatibility, formatting/checkstyle, focused transaction-time tests, Liquibase DDL safety, and Liquibase-only runs against both PostgreSQL and MariaDB with actual column type verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
