adamsaghy commented on code in PR #6187:
URL: https://github.com/apache/fineract/pull/6187#discussion_r3704896277
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -191,6 +195,20 @@ public static SavingsAccountTransactionData create(final
Long id, final SavingsA
false);
}
+ public static SavingsAccountTransactionData create(final Long id, final
SavingsAccountTransactionEnumData transactionType,
Review Comment:
Instead of creating the N+1 constructor, would you be open to rewrite these
using builder pattern instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
