adamsaghy commented on code in PR #6176:
URL: https://github.com/apache/fineract/pull/6176#discussion_r3703373141
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/businessdate/service/BusinessDateWritePlatformServiceImpl.java:
##########
@@ -52,6 +54,7 @@ public BusinessDateDTO updateBusinessDate(BusinessDateDTO
businessDateDto) {
}
@Override
+ @Transactional(propagation = Propagation.REQUIRES_NEW)
Review Comment:
I dont think this should be in new transaction. This way we detach the
result from the job status and business date can be increased while the job can
still fail for any reasons...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
