vidakovic commented on code in PR #6034: URL: https://github.com/apache/fineract/pull/6034#discussion_r3747973142
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/account/data/request/StandingInstructionRequestParser.java: ########## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.account.data.request; + +import java.math.BigDecimal; +import java.time.LocalDate; +import java.time.MonthDay; +import java.time.format.DateTimeFormatter; +import java.time.format.DateTimeFormatterBuilder; +import java.util.Locale; +import org.apache.commons.lang3.StringUtils; + +/** + * Locale-aware parsing helpers for the {@code String}-based standing instruction request DTOs. Shared by + * {@code StandingInstructionRequestDataValidator} (validation) and {@code StandingInstructionWriteServiceImpl} (entity + * assembly) so both interpret the raw request values identically. + */ +public final class StandingInstructionRequestParser { Review Comment: Why is it necessary to hide the use of commons `StringUtils`? I didn't check, but if these utility functions here are only called in exactly one place (I have a suspicion) then all this is not worth it and just plays hide and seek with your fellow developers. Please check for yourself and see if you can avoid this boilerplate class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
