vidakovic commented on code in PR #6034:
URL: https://github.com/apache/fineract/pull/6034#discussion_r3748003880
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferStandingInstruction.java:
##########
@@ -144,7 +143,9 @@ private AccountTransferStandingInstruction(final
AccountTransferDetails accountT
}
}
- public Map<String, Object> update(JsonCommand command) {
+ public Map<String, Object> update(final BigDecimal amount, final LocalDate
validFrom, final LocalDate validTill, final Integer status,
Review Comment:
I am almost certain that this function is called only in one place (the
update command/use case). Please leave the entity classes as pure as possible
otherwise other developers will feel tempted to overload this class with
additional business logic/functionality... entity classes are not the place for
this.
In short: move this to the service class where it belongs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
