opensource-joe commented on issue #355: URL: https://github.com/apache/fineract-backoffice-ui/issues/355#issuecomment-5303519893
@Aman-Mittal flagging this one too, as the other half of what #339 left behind. #250 scoped the per-feature refinement as newcomer tasks, and this is what is actually left of it now that `TranslatedTitleStrategy` and the 25 section titles have landed. Nothing here is broken, so there is no urgency. Inheritance means every page already gets a sensible title. It is just that 65 routes under `products` all get the same one. Two things I would rather ask than assume: 1. **How would you like it split?** One PR for all 21 files is a large and very repetitive diff. 21 PRs is a lot of review. My guess is the four big ones separately and the rest grouped, but it is your review time, so you decide. 2. **How many should I leave alone?** These are genuinely good first issues and I do not want to take work that is more useful sitting there for someone new. Say the word and I will take only the four large files, or none at all, and just leave the list. Also a correction to myself: #339's description said 22 route files remained. Measured against current `main` it is 21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
