Aman-Mittal commented on issue #355: URL: https://github.com/apache/fineract-backoffice-ui/issues/355#issuecomment-5306028456
You are right that those two paragraphs contradict each other, and your reading is the one I meant. Take **clients, products and system**. `accounting`, `loans` and the 16 small files stay open. Clients specifically, rather than something smaller, because it is the only mid-size file that carries every shape the convention has to answer: empty path, `create`, `edit/:id`, `view/:id`, and two-level nested sub-resources (`:clientId/identifiers/edit/:id`, `:clientId/collaterals/create`). The small files mostly do not — `settings` is five flat paths, `campaigns` is list/create/edit per channel. If the convention gets settled on one of those, the nested sub-resource case is still unanswered when 18 later PRs hit it, and that is exactly the one people will answer differently from each other. So clients is not just a small file for the purpose, it is the one that forces the decisions. One extra case to cover while you are writing those decisions back: `tellers` goes a level deeper than clients does — `:tellerId/cashiers/:cashierId/transactions/:command`. Whoever picks that file up will be the only person to hit three levels plus a `:command` segment, so a line on it in #355 will save them guessing. That still leaves 18 of the 21 files and a bit over half the routes for other people, which is more than enough queue. Thanks for leaving `products.routes.ts` flat. I will get to #365. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
