Aman-Mittal opened a new issue, #405:
URL: https://github.com/apache/fineract-backoffice-ui/issues/405

   Part of #403. **Good first issue** — a smaller batch than #404, fully 
mechanical, and a good one to take if you want to try the workflow before 
committing to a bigger area.
   
   ## What to do
   
   All 15 specs under `src/app/features/accounting/` still run on the 
deprecated Karma runner:
   
   ```bash
   node scripts/codemod-jasmine-to-vitest.mjs $(node -p 
"require('./karma-baseline.json').specs.filter(f=>f.startsWith('src/app/features/accounting/')).join('
 ')")
   npm run test:unit
   node scripts/check-test-runner.mjs --write
   npm run lint:prune && npm run format
   npm test -- --watch=false
   ```
   
   All 15 convert cleanly — the codemod reports `0 left for a human` for this 
area.
   
   ## Acceptance criteria
   
   - [ ] No `.spec.ts` files remain under `src/app/features/accounting/`
   - [ ] `npm run test:unit` and `npm test -- --watch=false` both pass
   - [ ] Karma total + Vitest total unchanged — quote both in the PR
   - [ ] `karma-baseline.json` updated in the same commit
   - [ ] `npm run lint` and `npm run format:check` clean
   
   ## Things that trip people up
   
   - Run `npm run lint:prune` after the rename: `eslint-suppressions.json` is 
keyed by path, so renaming orphans entries. The total count should not change, 
only the paths.
   - Migrate as-is. If a spec looks wrong, open a separate issue rather than 
fixing it in the same diff.
   
   Background: 
[`DOCS/adr/0004-vitest-migration.md`](DOCS/adr/0004-vitest-migration.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to