rymghosn commented on PR #6128: URL: https://github.com/apache/fineract/pull/6128#issuecomment-5352249591
Hi @adamsaghy @Aman-Mittal — I've rebased onto latest `develop` (commit `47416e074`), and it looks like this fixed the `SavingsInterestPostingTest` failures from the previous run. However, CI now shows a new failure on Shard 2 of 15, on all three DB engines (MySQL, MariaDB, PostgreSQL): ``` org.apache.fineract.integrationtests.SavingsAccountsExternalIdTest.submitSavingsAccountsApplication() CallFailedRuntimeException: HTTP 404 — "Saving product with identifier 1 does not exist" ``` This is the same class of issue we diagnosed earlier on this PR (the Shard 4 / `UndoRepaymentWithDownPaymentIntegrationTest` failure from 2026-07-15): `SavingsAccountsExternalIdTest` hardcodes `productId=1L` (`SavingsAccountsExternalIdTest.java:61`) and relies on some other test class that runs earlier in the same shard/JVM to have already created a savings product with id 1. Adding `LoanDisbursementMakerCheckerIntegrationTest` shifts the alphabetical round-robin shard assignment of every test class that sorts after it, so after the rebase this pre-existing test-order dependency now surfaces in Shard 2 instead of Shard 4. Our production changes are guarded behind the `MAKER_CHECKER` config flag (default disabled), so they're not exercised in this test's execution path — this isn't a regression from our code. Could you take a look and let us know how you'd like to proceed — re-run the job, or any other guidance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
