adamsaghy commented on code in PR #6330:
URL: https://github.com/apache/fineract/pull/6330#discussion_r3864135989
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailDataValidator.java:
##########
@@ -59,185 +50,39 @@ public EmailDataValidator(final FromJsonHelper
fromApiJsonHelper) {
}
/**
- * validate the request to create a new report mailing job
+ * validate the request to create a new email message
*
* @param jsonCommand
* -- the JSON command object (instance of the JsonCommand
class)
* @return None
**/
public void validateCreateRequest(final JsonCommand jsonCommand) {
final String jsonString = jsonCommand.json();
- final JsonElement jsonElement = jsonCommand.parsedJson();
if (StringUtils.isBlank(jsonString)) {
throw new InvalidJsonException();
}
final Type typeToken = new TypeToken<Map<String, Object>>()
{}.getType();
- this.fromApiJsonHelper.checkForUnsupportedParameters(typeToken,
jsonString, ScheduledEmailConstants.CREATE_REQUEST_PARAMETERS);
Review Comment:
Why to remove all these validations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
