AshharAhmadKhan commented on PR #6330: URL: https://github.com/apache/fineract/pull/6330#issuecomment-5428748333
> > > Why to remove all these validations? > > > > > > hey Adam, those validations are for the scheduled mailing job resource, not /v1/email. This is mentioned in the JIRA ticket ([FINERACT-2785](https://issues.apache.org/jira/browse/FINERACT-2785)). > > EmailMessageAssembler only reads groupId, clientId, staffId, message and emailSubject for this endpoint. The fields being validated here (name, startDateTime, stretchyReportId, emailRecipients, emailAttachmentFileFormatId) all belong to ScheduledEmailConstants, a different resource entirely. None of them exist in EmailApiConstants. > > So that validation was never really covering /v1/email input. It's also why the real params were getting rejected as unsupported in the first place. > > I did not add new required field validation for the real params here on purpose, to avoid scope creep. Planning to raise that as a separate PR once this one is in. > > Thank you for the explanation. Now it makes sense: but I would like you to add it as part of this PR. We dont need a separate PR to fix the validations. done thanks adam! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
