budaidev commented on code in PR #6264:
URL: https://github.com/apache/fineract/pull/6264#discussion_r3947723809


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/domain/WorkingCapitalLoanPeriodPaymentRateChange.java:
##########
@@ -62,6 +62,16 @@ public class WorkingCapitalLoanPeriodPaymentRateChange 
extends AbstractAuditable
     @Column(name = "submitted_on_date", nullable = false)
     private LocalDate submittedOnDate;
 
+    /** Snapshot taken when the change was booked, never restated; null for 
changes booked before it existed. */
+    @Column(name = "calculated_annual_eir", scale = 6, precision = 19)
+    private BigDecimal calculatedAnnualEir;

Review Comment:
   fixed



##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalPeriodPaymentRate.feature:
##########
@@ -371,6 +371,10 @@ Feature: Working Capital Period Payment Rate
       | Effective Date  | Previous Rate | New Rate | Reversed |
       | 10 January 2026 | 18.0          | 11.0     | false    |
       | 20 January 2026 | 11.0          | 20.0     | false    |
+    And Working capital loan account has the correct period payment rate 
history data:
+      | effectiveDate   | previousRate | newRate | calculatedAnnualEIR | 
dailyPaymentAmount | segmentTerm | reversed |
+      | 10 January 2026 | 18.0         | 11.0    | 0.265288            | 30.56 
             | 328         | false    |

Review Comment:
   fixed to percentage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to