adamsaghy commented on code in PR #6264:
URL: https://github.com/apache/fineract/pull/6264#discussion_r3971260180
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalPeriodPaymentRate.feature:
##########
@@ -1840,6 +1873,9 @@ Feature: Working Capital Period Payment Rate
| 04 January 2026 | Repayment | 50.0 | 50.0
| 0.0 | 0.0 | false |
| 04 January 2026 | Discount Fee Amortization | 8.45 |
| | | false |
| 21 January 2026 | Repayment | 55.56 |
55.56 | 0.0 | 0.0 | false |
+ And Working capital loan account has the correct period payment rate
history data:
+ | effectiveDate | previousRate | newRate | calculatedAnnualEIR |
dailyPaymentAmount | segmentTerm | reversed |
+ | 20 January 2026 | 18.0 | 20.0 | 2740.680185 | 55.56
| 19 | false |
Review Comment:
This seems way too big
##########
fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalPeriodPaymentRate.feature:
##########
@@ -1944,6 +1980,9 @@ Feature: Working Capital Period Payment Rate
| 01 January 2026 | Disbursement | 1000.0 |
1000.0 | 0.0 | 0.0 | false |
| 01 January 2026 | Discount Fee | 100.0 |
100.0 | 0.0 | 0.0 | false |
| 21 January 2026 | Repayment | 55.56 |
55.56 | 0.0 | 0.0 | false |
+ And Working capital loan account has the correct period payment rate
history data:
+ | effectiveDate | previousRate | newRate | calculatedAnnualEIR |
dailyPaymentAmount | segmentTerm | reversed |
+ | 20 January 2026 | 18.0 | 20.0 | 2741.704245 | 55.56
| 20 | false |
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
