adamsaghy commented on code in PR #6425:
URL: https://github.com/apache/fineract/pull/6425#discussion_r4071992986
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformServiceImpl.java:
##########
@@ -199,6 +205,76 @@ public List<ChargeData> retrieveLoanProductCharges(final
Long loanProductId, fin
return this.jdbcTemplate.query(sql, rm, new Object[] { loanProductId,
chargeTime.getValue() }); // NOSONAR
}
+ @Override
+ public List<ChargeData> retrieveWorkingCapitalLoanApplicableFees() {
+ return retrieveWorkingCapitalLoanApplicableCharges(false);
+ }
+
+ @Override
+ public List<ChargeData> retrieveWorkingCapitalLoanApplicablePenalties() {
+ return retrieveWorkingCapitalLoanApplicableCharges(true);
+ }
+
+ @Override
+ public List<ChargeData>
retrieveWorkingCapitalLoanApplicableFeesForCurrency(final String currencyCode) {
+ final Integer chargeAppliesTo =
ChargeAppliesTo.WORKING_CAPITAL_LOAN.getValue();
+ final List<Long> officeChargeIds = chargeIdsVisibleToUserOffice();
+ final List<Charge> charges = officeChargeIds == null
+ ?
chargeRepository.findWorkingCapitalLoanApplicableChargesForCurrency(false,
chargeAppliesTo, currencyCode)
+ :
chargeRepository.findWorkingCapitalLoanApplicableChargesForCurrencyAndOffice(false,
chargeAppliesTo, currencyCode,
+ officeChargeIds);
+ return toChargeDataList(charges);
+ }
+
+ @Override
+ public List<ChargeData> retrieveWorkingCapitalLoanProductCharges(final
Long workingCapitalLoanProductId) {
+ final List<Long> officeChargeIds = chargeIdsVisibleToUserOffice();
+ final List<Charge> charges = officeChargeIds == null
+ ?
chargeRepository.findWorkingCapitalLoanProductCharges(workingCapitalLoanProductId)
+ :
chargeRepository.findWorkingCapitalLoanProductChargesForOffice(workingCapitalLoanProductId,
officeChargeIds);
+ return toChargeDataList(charges);
+ }
+
+ private List<ChargeData> retrieveWorkingCapitalLoanApplicableCharges(final
boolean penalty) {
+ final Integer chargeAppliesTo =
ChargeAppliesTo.WORKING_CAPITAL_LOAN.getValue();
+ final List<Long> officeChargeIds = chargeIdsVisibleToUserOffice();
+ final List<Charge> charges = officeChargeIds == null
+ ?
chargeRepository.findWorkingCapitalLoanApplicableCharges(penalty,
chargeAppliesTo)
+ :
chargeRepository.findWorkingCapitalLoanApplicableChargesForOffice(penalty,
chargeAppliesTo, officeChargeIds);
+ return toChargeDataList(charges);
+ }
+
+ /**
+ * Charge ids the current user's office is allowed to see, or {@code null}
when office specific products are
+ * disabled and every charge is visible. The entity access service hands
the ids over as the comma separated body of
+ * a SQL IN clause, so they are parsed back into a list the JPQL queries
can bind.
+ */
+ private List<Long> chargeIdsVisibleToUserOffice() {
+ final String inClause = fineractEntityAccessUtil
+
.getSQLWhereClauseForProductIDsForUserOffice_ifGlobalConfigEnabled(FineractEntityType.CHARGE);
Review Comment:
Can we rather introduce a new method which gives as exactly what we need,
instead of String magic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
