adamsaghy commented on code in PR #6425:
URL: https://github.com/apache/fineract/pull/6425#discussion_r4072007983
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformServiceImpl.java:
##########
@@ -459,8 +535,14 @@ public List<ChargeData>
retrieveWorkingCapitalLoanAccountApplicableCharges(Long
paramMap.put("loanId", loanId);
paramMap.put("chargeAppliesTo",
ChargeAppliesTo.WORKING_CAPITAL_LOAN.getValue());
paramMap.put("chargeTimeTypes",
ChargeTimeType.validWorkingCapitalLoanAccountValues());
- String sql = "select " + rm.chargeSchema() + " join m_wc_loan la on
la.currency_code = c.currency_code" + " where la.id=:loanId"
- + " and c.is_deleted=false and c.is_active=true and
c.charge_applies_to_enum=:chargeAppliesTo"
+ // Only the charges catalogued by the loan's own product are offered,
so the template cannot suggest a charge
Review Comment:
Since we touch it, lets rewrite it use Repository + JPQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
