Aman-Mittal commented on PR #625: URL: https://github.com/apache/fineract-backoffice-ui/pull/625#issuecomment-5848903068
Two things, one of them my mistake. ### The `detect-unsafe-regex` annotation I said in the last comment that I had replaced the handler's key-shape regex with two linear checks. I had — in the working tree, and then pushed without committing it, so `e99f6984` still carried the original and the annotation stayed on line 47. Squashed into `b9cfa209` where it belongs and force-pushed; HEAD is now `247461e4`. For the record it was an annotation rather than a failure — the `TS/ESLint` job reported `success` on both runs — but it was noise this branch introduced and it should not have survived two pushes. ### Local verification on the rebased tree ``` npx playwright test --project=mocked --project=mobile 6 skipped 373 passed (13.4m) [exited with code 0] ``` Green with the fixture enforcing, on top of `origin/main` at `a4770751`. ### State of the branch Six commits, all signed, rebased and squashed clean: | | | | --- | --- | | `ea109656` | `fix(nav)` — the three hardcoded sidebar groups | | `c2dcb8de` | `ci(i18n)` — the widened checks, the catalogue ratchet, the runtime handler and fixture | | `2fbf1a7b` | `fix(i18n)` — 47 phrase column headers | | `69ad1205` | `ci(i18n)` — the `PHRASES` check, and stop scanning test files | | `b9cfa209` | `fix(i18n)` — stop reporting deployment branding overrides | | `247461e4` | `fix(clients)` — `ACTIONS.UNDO_REJECT_CLIENT` | Local: `lint` (clean, no warnings), `format:check`, `typecheck:e2e`, `check:nav-ids`, all four `i18n:check` checks, 1581 unit tests, 373 e2e. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
