Aman-Mittal commented on PR #625:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/625#issuecomment-5848960938
The last CI failure — `loan-servicing-gaps.spec.ts` reporting
`LOANS.EXTERNAL_ID` — turned out to expose a gap between the two checks rather
than a one-line typo.
### Each check was doing half the job
`PHRASES` proves a `ColumnDef.label` is *shaped* like a key. Nothing proved
the key was *real*, because `label:` was not among the reference forms
`MISSING` scans: it matched `label=` in a template and `labelKey:` in the nav
config, but not `label:` in a ColumnDef array. **165 references went
unchecked.**
So `loan-originators-tab.component.ts` naming `LOANS.EXTERNAL_ID` passed
both checks and rendered the key. The catalogue defines `COMMON.EXTERNAL_ID`;
nothing compared the two.
### Adding the pattern found a second one
```
✖ 2 key(s) referenced in code but MISSING from en.json:
COMMON.REASON
(loans/rescheduling/reschedule-requests-list.component.ts:98)
LOANS.EXTERNAL_ID (loans/tabs/loan-originators-tab.component.ts:49)
```
`COMMON.REASON` has no spec anywhere near it — the e2e gate would never have
found it. Its two neighbours in the same array are `COMMON.STATUS` and
`COMMON.ACTIONS`, both real, so it looked entirely ordinary. Added the key
rather than repointing the reference, since the surrounding array is already
COMMON-based.
`LOANS.EXTERNAL_ID` now points at `COMMON.EXTERNAL_ID`.
Checked references: **2034 → 2198**.
### Verified
- `npm run i18n:check` — all four checks pass
- `npm run format:check`, `npm run check:nav-ids` — clean
- `npx playwright test --project=mocked loan-servicing-gaps.spec.ts
loan-servicing.spec.ts` — **14 passed** (was 13 passed, 1 failed)
### A correction
I reported the earlier full local run as green at 373 passed, and this spec
was in it — it passed locally and failed on CI, where retries surfaced it. The
local result was accurate but weaker evidence than I presented it as. CI
remains the authority here, which is the honest reading of all three failures
on this branch: each one found something a local run had not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
