priyam99 opened a new pull request, #140: URL: https://github.com/apache/fineract-loan-origination/pull/140
## Description Adds a vendor-neutral `AGENTS.md` and a lightweight pull request template with an optional AI disclosure section, as proposed in #131. This follows the dev@ discussions on AI-assisted development ([Backoffice UI release thread](https://lists.apache.org/thread/fo3rdlb92f88o84s5dgqyosk6cnmmgd2), [AI guidelines thread](https://lists.apache.org/thread/hj6qwkczmgc4rmhcho7goqdzgd0652mg)) and the AI Policy added to Fineract's CONTRIBUTING.md in FINERACT-2800 (apache/fineract#6366). JIRA: [FINERACT-2442](https://issues.apache.org/jira/browse/FINERACT-2442) Closes #131 **`AGENTS.md`** - Adopts Fineract's AI Policy as is: the human submitter stays accountable, AI use is disclosed with an `Assisted-By:` trailer, and contributions follow the ASF Generative Tooling Guidance. It adds working rules for agents that came out of the dev@ concerns: no commits or pushes without the human, signed commits only, small PRs, reuse before reinventing, and no AI-only review. - Lists the Maven build, test, format, and RAT commands and the frontend npm commands, with notes on local setup. - Includes a repository map and the architecture rules the code depends on: state machine-only status changes, pluggable server-side scoring, Fineract behind `FineractLoanApiClient`, tenant isolation, configuration-driven approval stages, and how errors are handled. - Covers conventions (Lombok, logging, Flyway, license headers, dependencies, frontend), testing, and security. - Has a "Where the docs and the code disagree" section so agents and new contributors trust the code where the docs have drifted. **`.github/PULL_REQUEST_TEMPLATE.md`** - Contains Description, Verification (this repo's Maven and npm checks), an optional AI assistance section, and a checklist. The checklist is based on Fineract's template and links to the AI Policy. - AI disclosure is optional and does not gate contributions. No functional code, tests, or configuration are changed. Following the naming discussion on dev@, the file is `AGENTS.md` rather than `CLAUDE.md`. **Found while writing this but not fixed here** (can follow up separately): - Two Flyway migrations share version 8 (`V8__add_fineract_client_id.sql`, `V8__create_staff_credentials.sql`). - `docker/docker-compose.yml` refers to a `Dockerfile` that does not exist. - `los-api-spec-sync.yml` writes to `frontend/openapi/` and `frontend/src/app/api/`, and neither exists. ## Verification - [x] `./mvnw apache-rat:check`: both new files carry the ASF header; 0 unapproved. - [x] Every statement in `AGENTS.md` was checked against the current source on `main` (classes, config keys, commands, paths). - [ ] `./mvnw spotless:apply` / `./mvnw clean verify`: not applicable, because this is a documentation-only change. - [ ] Frontend checks: not applicable, because there are no frontend changes. ## AI assistance (optional) - Tool / model: Claude Code (Claude Opus 5.5) - How it was used: read the mailing-list threads, the existing docs, and the source, then drafted both files. I reviewed and edited every line and checked each claim against the code. ## Checklist - [x] The PR title and commit messages start with the JIRA issue and an imperative verb. - [x] This PR is one logical change, not a code dump. - [x] I added or updated tests, or explained why tests are not needed (documentation only). - [x] New files carry the ASF license header. - [x] Docs are updated. - [x] All commits are signed. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy) and the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
